[dice] Refactor some dice related constants and APIs #25023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommychiu-github
requested review from
pamaury
and removed request for
a team
|
@timothytrippel for viz. |
tommychiu-github
force-pushed
the
main
branch
2 times, most recently
from
3567df4 to
6c60a5c
Compare
It'll be invoked by several modules, so move it to base:util library for code reuse. Signed-off-by: Tommy Chiu <[email protected]>
Both X509 and CWT DICE implementations need these definitions. Move it out from the original source file for code reuse. Signed-off-by: Tommy Chiu <[email protected]>
tommychiu-github
force-pushed
the
main
branch
from
6c60a5c to
ed85a17
Compare
tommychiu-github
force-pushed
the
main
branch
from
ed85a17 to
44907b5
Compare
The autogen source from templates needs some more APIs to utilize the Cbor structure, including - calculate the size of a given cbor argument - add a bstr/tstr header with size, and rewind the cursor - copy the raw data from input pointer to the CborOut buffer Signed-off-by: Tommy Chiu <[email protected]>
tommychiu-github
force-pushed
the
main
branch
from
44907b5 to
c735b28
Compare
timothytrippel
approved these changes
Nov 8, 2024
timothytrippel
added
the
CherryPick:earlgrey_1.0.0
|
Successfully created backport PR for |
|
Git push to origin failed for earlgrey_1.0.0 with exitcode 1 |
github-actions
bot
added
the
Manually CherryPick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some DICE key creation constants and utilities are invoked by several modules.
Refactor them for a better code reuse.